Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect Protobuf FileDescriptor references #989

Merged
merged 4 commits into from
May 16, 2023
Merged

Conversation

milindl
Copy link
Contributor

@milindl milindl commented Apr 25, 2023

Internal PR for #887 so that CI can run.

Mrmann87 and others added 2 commits April 25, 2023 14:10
Fixes several well known types were referencing incorrect descriptors.
Additionally, changes the field behavior and source context imports,
which are part of the standard protobuf distribution, to google.golang.org/protobuf
instead of google.golang.org/genproto.
Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milindl milindl merged commit acd3a1e into master May 16, 2023
@milindl milindl deleted the dev_descriptor_refs branch May 16, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants